<html>
<head><meta charset="utf-8"><title>broken rust docs links · general · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/index.html">general</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html">broken rust docs links</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="215560152"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215560152" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215560152">(Nov 04 2020 at 09:52)</a>:</h4>
<p>Some of the links that show up as search results seem broken.</p>
<p>Eg: <a href="https://doc.rust-lang.org/stable/nightly-rustc/rustc_middle/ty/struct.Binder.html?search=visit_with">https://doc.rust-lang.org/stable/nightly-rustc/rustc_middle/ty/struct.Binder.html?search=visit_with</a></p>
<p>And if I go to <code>https://doc.rust-lang.org/stable/nightly-rustc/rustc_middle/type.Ty.html#method.visit_with</code> (The first one in the results)</p>



<a name="215560227"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215560227" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215560227">(Nov 04 2020 at 09:53)</a>:</h4>
<p><span class="user-mention" data-user-id="281950">@Aman Arora</span> can you open a rustdoc issue on rust-lang/rust?</p>



<a name="215560273"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215560273" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215560273">(Nov 04 2020 at 09:54)</a>:</h4>
<p>Will do</p>



<a name="215560841"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215560841" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215560841">(Nov 04 2020 at 10:00)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/issues/78724">https://github.com/rust-lang/rust/issues/78724</a><br>
I couldn't find a rustdoc issue template, let me know if I should add more info</p>



<a name="215560856"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215560856" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215560856">(Nov 04 2020 at 10:00)</a>:</h4>
<p>ooh that's a good idea</p>



<a name="215560866"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215560866" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215560866">(Nov 04 2020 at 10:00)</a>:</h4>
<p><span class="user-mention" data-user-id="219696">@XAMPPRocky</span> what do you think about a rustdoc issue template?</p>



<a name="215560882"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215560882" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215560882">(Nov 04 2020 at 10:00)</a>:</h4>
<p>e.g. we don't need <code>rustc -vV</code>, just <code>rustdoc -v</code></p>



<a name="215560908"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215560908" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215560908">(Nov 04 2020 at 10:01)</a>:</h4>
<p>but we <em>definitely</em> need 'can you reproduce with cargo doc and not just <a href="http://docs.rs">docs.rs</a>'</p>



<a name="215560936"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215560936" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215560936">(Nov 04 2020 at 10:01)</a>:</h4>
<p>plus adding t-rustdoc automatically would be nice</p>



<a name="215561039"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215561039" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215561039">(Nov 04 2020 at 10:02)</a>:</h4>
<p>Seems like a good idea to me, I remember there was talk at some stage of moving rustdoc out of repo, but I think it would be fine to have an issue template until whenever/if that happens.</p>



<a name="215561063"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215561063" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215561063">(Nov 04 2020 at 10:02)</a>:</h4>
<p>honestly having rustdoc in-tree is not so bad, it's the compile times</p>



<a name="215561103"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215561103" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215561103">(Nov 04 2020 at 10:03)</a>:</h4>
<p>and it turns out <span class="user-mention" data-user-id="132040">@Manish Goregaokar</span> knew a way this whole time not to have to build from source <span aria-label="laughing" class="emoji emoji-1f606" role="img" title="laughing">:laughing:</span> <a href="https://github.com/rust-lang/rustc-dev-guide/issues/942">https://github.com/rust-lang/rustc-dev-guide/issues/942</a></p>



<a name="215561148"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215561148" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215561148">(Nov 04 2020 at 10:03)</a>:</h4>
<p>(manish, what does RTIM mean?)</p>



<a name="215561237"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215561237" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215561237">(Nov 04 2020 at 10:04)</a>:</h4>
<p>but I certainly wouldn't be <em>opposed</em> to having rustdoc out of tree if we used subtree</p>



<a name="215561249"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215561249" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215561249">(Nov 04 2020 at 10:04)</a>:</h4>
<p>rustup-toolchain-install-master?</p>



<a name="215561262"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215561262" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215561262">(Nov 04 2020 at 10:04)</a>:</h4>
<p>hard pass for submodules though :P</p>



<a name="215561274"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215561274" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215561274">(Nov 04 2020 at 10:05)</a>:</h4>
<p><a href="https://github.com/kennytm/rustup-toolchain-install-master">https://github.com/kennytm/rustup-toolchain-install-master</a></p>



<a name="215561302"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215561302" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215561302">(Nov 04 2020 at 10:05)</a>:</h4>
<p>clippy and rustfmt use it too IIRC</p>



<a name="215596952"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215596952" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215596952">(Nov 04 2020 at 15:31)</a>:</h4>
<p><span class="user-mention" data-user-id="232545">@Joshua Nelson</span> no, clippy uses subtree</p>



<a name="215596988"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215596988" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215596988">(Nov 04 2020 at 15:31)</a>:</h4>
<p>i've been talking about this for ages, rustdoc would be perfect with what clippy does</p>



<a name="215597051"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597051" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597051">(Nov 04 2020 at 15:32)</a>:</h4>
<p>use RTIM, separate repo, and use <code>git subtree</code> to also have it be in tree</p>



<a name="215597149"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597149" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597149">(Nov 04 2020 at 15:32)</a>:</h4>
<p><span class="user-mention" data-user-id="132040">@Manish Goregaokar</span> I chatted with <span class="user-mention" data-user-id="210316">@GuillaumeGomez</span> about it yesterday, the issue is that rustdoc uses compiletest which only runs in-tree</p>



<a name="215597155"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597155" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597155">(Nov 04 2020 at 15:32)</a>:</h4>
<p>means that rustc devs can continue to not care about rustdoc's repo, and we do occasional (clippy does biweekly, rustdoc would be fewer) syncs</p>



<a name="215597178"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597178" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597178">(Nov 04 2020 at 15:32)</a>:</h4>
<p><span class="user-mention" data-user-id="232545">@Joshua Nelson</span> incorrect, clippy also uses compiletest</p>



<a name="215597201"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597201" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597201">(Nov 04 2020 at 15:32)</a>:</h4>
<p>there's an out of tree copy</p>



<a name="215597202"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597202" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597202">(Nov 04 2020 at 15:32)</a>:</h4>
<p>And it also makes adding lints very painful because right now they're all hard-coded in rustc_lint</p>



<a name="215597255"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597255" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597255">(Nov 04 2020 at 15:33)</a>:</h4>
<p><span class="user-mention" data-user-id="232545">@Joshua Nelson</span> no, that's why subtree is good, you can add lints to the rustc repo then</p>



<a name="215597282"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597282" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597282">(Nov 04 2020 at 15:33)</a>:</h4>
<p>i've explained all this to <span class="user-mention" data-user-id="210316">@GuillaumeGomez</span> before, bit annoyed they don't remember</p>



<a name="215597299"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597299" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597299">(Nov 04 2020 at 15:33)</a>:</h4>
<blockquote>
<p>there's an out of tree copy</p>
</blockquote>
<p>Does it support htmldocck and the JS tests?</p>



<a name="215597341"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597341" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597341">(Nov 04 2020 at 15:33)</a>:</h4>
<p>unsure but it's basically a copy of the in tree one so it should</p>



<a name="215597376"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597376" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597376">(Nov 04 2020 at 15:33)</a>:</h4>
<blockquote>
<p>you can add lints to the rustc repo then</p>
</blockquote>
<p>That's not my point - that means you can't test the lints until you do the subtree sync</p>



<a name="215597460"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597460" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597460">(Nov 04 2020 at 15:34)</a>:</h4>
<p>why not?</p>



<a name="215597499"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597499" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597499">(Nov 04 2020 at 15:34)</a>:</h4>
<p>a subtree is not a submodule</p>



<a name="215597501"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597501" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> GuillaumeGomez <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597501">(Nov 04 2020 at 15:34)</a>:</h4>
<p>Also, it wasn't the only issue, I suggested to postpone the discussion until the rustdoc cleanup is done</p>



<a name="215597537"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597537" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597537">(Nov 04 2020 at 15:34)</a>:</h4>
<p>from the rustc repo's side things look _exactly the same_ as today</p>



<a name="215597565"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597565" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597565">(Nov 04 2020 at 15:34)</a>:</h4>
<p>though rustc may use the out of tree compiletest</p>



<a name="215597602"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597602" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597602">(Nov 04 2020 at 15:35)</a>:</h4>
<p>They don't exist yet</p>



<a name="215597616"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597616" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597616">(Nov 04 2020 at 15:35)</a>:</h4>
<p>aside: there's a general desire to stop using the out-of-tree compiletest and instead just autopublish the in-tree compiletest</p>



<a name="215597650"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597650" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597650">(Nov 04 2020 at 15:35)</a>:</h4>
<p><span class="user-mention" data-user-id="232545">@Joshua Nelson</span> a subtree is not a submodule</p>



<a name="215597680"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597680" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597680">(Nov 04 2020 at 15:35)</a>:</h4>
<p>this entire issue is a misunderstanding of what i am proposing</p>



<a name="215597761"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597761" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597761">(Nov 04 2020 at 15:35)</a>:</h4>
<p><span class="user-mention" data-user-id="232545">@Joshua Nelson</span> with a subtree rustdoc's code stays exactly where it is, but there is _also_ a second repo. there is a git subcommand that can sync the two.</p>



<a name="215597765"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597765" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597765">(Nov 04 2020 at 15:35)</a>:</h4>
<p>I really don't understand then - how can we <em>possibly</em> make changes to rustc from out of tree</p>



<a name="215597823"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597823" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597823">(Nov 04 2020 at 15:36)</a>:</h4>
<p>you don't</p>



<a name="215597828"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597828" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597828">(Nov 04 2020 at 15:36)</a>:</h4>
<p>make them in tree</p>



<a name="215597850"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597850" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597850">(Nov 04 2020 at 15:36)</a>:</h4>
<p>if you want ot make a cross cutting change, make it in tree</p>



<a name="215597865"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597865" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597865">(Nov 04 2020 at 15:36)</a>:</h4>
<p>if you want to just add rustdoc features do that out of tree</p>



<a name="215597879"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597879" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597879">(Nov 04 2020 at 15:36)</a>:</h4>
<p>and sycn every now and then</p>



<a name="215597898"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215597898" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215597898">(Nov 04 2020 at 15:36)</a>:</h4>
<p>clippy does syncs biweekly and strategically when big stuff lands</p>



<a name="215598038"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215598038" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215598038">(Nov 04 2020 at 15:37)</a>:</h4>
<p>The issue tracking this is <a href="https://github.com/rust-lang/rust/issues/70651">https://github.com/rust-lang/rust/issues/70651</a> btw</p>



<a name="215598118"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215598118" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215598118">(Nov 04 2020 at 15:37)</a>:</h4>
<p>i have not pushed on rustdoc yet because i want to wait for the patches to <code>git subtree</code> that make it not choke on big repos on the first sync  to get upstreamed</p>



<a name="215598177"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215598177" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215598177">(Nov 04 2020 at 15:38)</a>:</h4>
<p>but i think both rustdoc and rustfmt should do this</p>



<a name="215598236"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215598236" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215598236">(Nov 04 2020 at 15:38)</a>:</h4>
<p>rustfmt's current situation is a pain for updates, and rustdoc's current situation makes it harder to contribute to</p>



<a name="215598319"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215598319" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215598319">(Nov 04 2020 at 15:38)</a>:</h4>
<p>clippy in part has such a vibrant community because you never need to build rustc to hack on it (except for the maintainers, occasionally)</p>



<a name="215633830"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215633830" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215633830">(Nov 04 2020 at 20:00)</a>:</h4>
<p><span class="user-mention silent" data-user-id="132040">Manish Goregaokar</span> <a href="#narrow/stream/122651-general/topic/broken.20rust.20docs.20links/near/215597850">said</a>:</p>
<blockquote>
<p>if you want ot make a cross cutting change, make it in tree</p>
</blockquote>
<p>how do you tell if something's a cross cutting change and when it isn't?</p>



<a name="215633882"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215633882" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215633882">(Nov 04 2020 at 20:01)</a>:</h4>
<p>for <a href="https://github.com/rust-lang/rust/pull/77820">https://github.com/rust-lang/rust/pull/77820</a> I expected it to be a pure refactor and ended up having to fix rustc bugs</p>



<a name="215633902"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215633902" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215633902">(Nov 04 2020 at 20:01)</a>:</h4>
<p>is there an easy way to take work in progress from out-of-tree and bring it in-tree?</p>



<a name="215634153"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215634153" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215634153">(Nov 04 2020 at 20:03)</a>:</h4>
<p><span class="user-mention silent" data-user-id="132040">Manish Goregaokar</span> <a href="#narrow/stream/122651-general/topic/broken.20rust.20docs.20links/near/215598319">said</a>:</p>
<blockquote>
<p>clippy in part has such a vibrant community because you never need to build rustc to hack on it (except for the maintainers, occasionally)</p>
</blockquote>
<p>FWIW I am 100% on board with making it so you don't have to compile rustc from source for rustdoc</p>



<a name="215634185"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215634185" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215634185">(Nov 04 2020 at 20:04)</a>:</h4>
<p>the thing I'm comparing it to is 'hacks with <code>rustup-toolchain-install-master</code> in-tree', not the current build process</p>



<a name="215634597"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215634597" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215634597">(Nov 04 2020 at 20:07)</a>:</h4>
<p><span class="user-mention silent" data-user-id="132040">Manish Goregaokar</span> <a href="#narrow/stream/122651-general/topic/broken.20rust.20docs.20links/near/215597341">said</a>:</p>
<blockquote>
<p>unsure but it's basically a copy of the in tree one so it should</p>
</blockquote>
<p>the in-tree compile test is separate from htmldocck, it's in src/etc IIRC</p>



<a name="215634625"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/broken%20rust%20docs%20links/near/215634625" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/broken.20rust.20docs.20links.html#215634625">(Nov 04 2020 at 20:07)</a>:</h4>
<p>but it would be reasonable to move it to <code>librustdoc/tests</code> or something so it gets synced without having to worry about it</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>